Subject: Re: [PATCH] bcmgenet: add WOL IRQ check

From: Florian Fainelli <[email-masked]>
Date: Thu, 13 Jan 2022 13:37:42 -0800

On 1/13/2022 1:00 PM, Andrew Lunn wrote:
> On Thu, Jan 13, 2022 at 10:46:07PM +0300, Sergey Shtylyov wrote:
>> The driver neglects to check the result of platform_get_irq_optional()'s
>> call and blithely passes the negative error codes to devm_request_irq()
>> (which takes *unsigned* IRQ #), causing it to fail with -EINVAL.
>> Stop calling devm_request_irq() with the invalid IRQ #s.
>>
>> Signed-off-by: Sergey Shtylyov <[email-masked]>
>>
>> ---
>> This patch is against DaveM's 'net.git' repo.
> 
> Since this is for net, it needs a Fixes: tag.
> 
> Fixes: 8562056f267d ("net: bcmgenet: request Wake-on-LAN interrupt")

I don't have strong objections whether we want to consider this a bug 
fix or not, but since the code only acts upon devm_request_irq() 
returning 0 meaning success, this seems more like an improvement rather 
than fixing an actual issue.
-- 
Florian