Subject: Re: Bond recovery from BOND_LINK_FAIL state not working

From: Jay Vosburgh <[email-masked]>
Date: Tue, 07 Nov 2017 11:47:50 +0900

Jarod Wilson <[email-masked]> wrote:

>On 2017-11-02 9:11 PM, Jay Vosburgh wrote:
[...]
>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>> index 18b58e1376f1..6f89f9981a6c 100644
>> --- a/drivers/net/bonding/bond_main.c
>> +++ b/drivers/net/bonding/bond_main.c
>> @@ -2046,6 +2046,7 @@ static int bond_miimon_inspect(struct bonding *bond)
>>     	bond_for_each_slave_rcu(bond, slave, iter) {
>>   		slave->new_link = BOND_LINK_NOCHANGE;
>> +		slave->link_new_state = slave->link;
>>     		link_state = bond_check_dev_link(bond, slave->dev, 0);
>>   
>>
>> 	Alex / Jarod, could you check my logic, and would you be able to
>> test this patch if my analysis appears sound?
>
>This patch looks good, the original reproducing setup successfully
>recovers after the original active slave goes down, even with
>NetworkManager in the mix.
>
>Reviewed-by: Jarod Wilson <[email-masked]>

	Thanks, I'll get a formal patch submission out later today.

	-J

---
	-Jay Vosburgh, [email-masked]