Subject: Re: [PATCHv4 net-next 0/3] Bonding: support new xfrm state offload functions

From: Jay Vosburgh <[email-masked]>
Date: Fri, 23 Aug 2024 13:48:26 -0700

Hangbin Liu <[email-masked]> wrote:

>Add 2 new xfrm state offload functions xdo_dev_state_advance_esn and
>xdo_dev_state_update_stats for bonding. The xdo_dev_state_free will be
>added by Jianbo's patchset [1]. I will add the bonding xfrm policy offload
>in future.

	These look ok to me from a code point of view, but I'm not
familiar enough with IPsec to comment on whether those aspects are
correct.  A cursory examiniation suggests that none of the new functions
being called might sleep.

	For the series:

Acked-by: Jay Vosburgh <[email-masked]>

	-J

>v4: Ratelimit pr_warn (Sabrina Dubroca)
>v3: Re-format bond_ipsec_dev, use slave_warn instead of WARN_ON (Nikolay Aleksandrov)
>    Fix bond_ipsec_dev defination, add *. (Simon Horman, kernel test robot)
>    Fix "real" typo (kernel test robot)
>v2: Add a function to process the common device checking (Nikolay Aleksandrov)
>    Remove unused variable (Simon Horman)
>v1: lore.kernel.org/netdev/[email-masked]
>
>Hangbin Liu (3):
>  bonding: add common function to check ipsec device
>  bonding: Add ESN support to IPSec HW offload
>  bonding: support xfrm state update
>
> drivers/net/bonding/bond_main.c | 97 ++++++++++++++++++++++++++++-----
> 1 file changed, 84 insertions(+), 13 deletions(-)
>
>-- 
>2.45.0

---
	-Jay Vosburgh, [email-masked]