From: Pavel Begunkov <asml.silence@gmail•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: David Wei <dw@davidwei•uk>,
io-uring@vger•kernel.org, netdev@vger•kernel.org,
Jens Axboe <axboe@kernel•dk>, Paolo Abeni <pabeni@redhat•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jesper Dangaard Brouer <hawk@kernel•org>,
David Ahern <dsahern@kernel•org>,
Mina Almasry <almasrymina@google•com>,
Stanislav Fomichev <stfomichev@gmail•com>,
Joe Damato <jdamato@fastly•com>,
Pedro Tammela <pctammela@mojatatu•com>
Subject: Re: [PATCH net-next v8 04/17] net: prepare for non devmem TCP memory providers
Date: Tue, 10 Dec 2024 04:15:13 +0000 [thread overview]
Message-ID: <1e1d368c-5a52-421c-9022-57166a8a3340@gmail.com> (raw)
In-Reply-To: <20241209200636.56a3dbae@kernel.org>
On 12/10/24 04:06, Jakub Kicinski wrote:
> On Tue, 10 Dec 2024 03:53:36 +0000 Pavel Begunkov wrote:
>>>> @@ -353,16 +356,16 @@ void page_pool_unlist(struct page_pool *pool)
>>>> int page_pool_check_memory_provider(struct net_device *dev,
>>>> struct netdev_rx_queue *rxq)
>>>> {
>>>> - struct net_devmem_dmabuf_binding *binding = rxq->mp_params.mp_priv;
>>>> + void *mp_priv = rxq->mp_params.mp_priv;
>>>> struct page_pool *pool;
>>>> struct hlist_node *n;
>>>>
>>>> - if (!binding)
>>>> + if (!mp_priv)
>>>> return 0;
>>>>
>>>> mutex_lock(&page_pools_lock);
>>>> hlist_for_each_entry_safe(pool, n, &dev->page_pools, user.list) {
>>>> - if (pool->mp_priv != binding)
>>>> + if (pool->mp_priv != mp_priv)
>>>> continue;
>>>>
>>>> if (pool->slow.queue_idx == get_netdev_rx_queue_index(rxq)) {
>>>
>>> appears to be unrelated
>>
>> The entire chunk? It removes the type, nobody should be blindly casting
>> it to devmem specific binding even if it's not referenced, otherwise it
>> gets pretty ugly pretty fast. E.g. people might assume that it's always
>> the right type to cast to.
>
> Change is good. It didn't feel very related to the other changes
> which specifically address devmem code. While this one only removes
> the type because the code itself isn't devmem specific. Right?
Right, and nobody cared because there wasn't anyone but devmem
prior to the series.
> if you make this chunk a separate patch #1 in the series I can apply it
> right away. pp->mp_priv is void *, this is a good cleanup regardless.
I can throw it into a separate patch, though let's just keep
it in the series as it'd complicate merging otherwise. Let's
say if it doesn't land this release, I'll send it separately
with 1/17 as clean ups.
--
Pavel Begunkov
next prev parent reply other threads:[~2024-12-10 4:14 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 17:21 [PATCH net-next v8 00/17] io_uring zero copy rx David Wei
2024-12-04 17:21 ` [PATCH net-next v8 01/17] net: prefix devmem specific helpers David Wei
2024-12-04 21:00 ` Mina Almasry
2024-12-04 21:24 ` David Wei
2024-12-04 17:21 ` [PATCH net-next v8 02/17] net: generalise net_iov chunk owners David Wei
2024-12-09 17:01 ` Mina Almasry
2024-12-04 17:21 ` [PATCH net-next v8 03/17] net: page_pool: create hooks for custom page providers David Wei
2024-12-10 3:02 ` Jakub Kicinski
2024-12-10 16:31 ` David Wei
2024-12-04 17:21 ` [PATCH net-next v8 04/17] net: prepare for non devmem TCP memory providers David Wei
2024-12-09 17:04 ` Mina Almasry
2024-12-10 3:15 ` Jakub Kicinski
2024-12-10 3:53 ` Pavel Begunkov
2024-12-10 4:06 ` Jakub Kicinski
2024-12-10 4:15 ` Pavel Begunkov [this message]
2024-12-04 17:21 ` [PATCH net-next v8 05/17] net: page_pool: add ->scrub mem provider callback David Wei
2024-12-09 17:08 ` Mina Almasry
2024-12-09 17:24 ` Pavel Begunkov
2024-12-04 17:21 ` [PATCH net-next v8 06/17] net: page pool: add helper creating area from pages David Wei
2024-12-10 3:29 ` Jakub Kicinski
2024-12-10 3:58 ` Pavel Begunkov
2024-12-04 17:21 ` [PATCH net-next v8 07/17] net: page_pool: introduce page_pool_mp_return_in_cache David Wei
2024-12-09 17:15 ` Mina Almasry
2024-12-09 17:28 ` Pavel Begunkov
2024-12-10 3:40 ` Jakub Kicinski
2024-12-10 4:31 ` Pavel Begunkov
2024-12-11 0:06 ` Jakub Kicinski
2024-12-04 17:21 ` [PATCH net-next v8 08/17] net: add helper executing custom callback from napi David Wei
2024-12-10 3:44 ` Jakub Kicinski
2024-12-10 4:11 ` Pavel Begunkov
2024-12-04 17:21 ` [PATCH net-next v8 09/17] io_uring/zcrx: add interface queue and refill queue David Wei
2024-12-06 16:05 ` Simon Horman
2024-12-09 23:50 ` David Wei
2024-12-10 3:49 ` Jakub Kicinski
2024-12-10 4:03 ` Pavel Begunkov
2024-12-10 4:07 ` Jakub Kicinski
2024-12-04 17:21 ` [PATCH net-next v8 10/17] io_uring/zcrx: add io_zcrx_area David Wei
2024-12-04 17:21 ` [PATCH net-next v8 11/17] io_uring/zcrx: implement zerocopy receive pp memory provider David Wei
2024-12-10 4:01 ` Jakub Kicinski
2024-12-10 4:45 ` Pavel Begunkov
2024-12-10 4:50 ` Pavel Begunkov
2024-12-11 0:24 ` Jakub Kicinski
2024-12-11 14:42 ` Pavel Begunkov
2024-12-12 1:38 ` Jakub Kicinski
2024-12-12 13:42 ` Pavel Begunkov
2024-12-10 16:55 ` Mina Almasry
2024-12-04 17:21 ` [PATCH net-next v8 12/17] io_uring/zcrx: add io_recvzc request David Wei
2024-12-04 17:21 ` [PATCH net-next v8 13/17] io_uring/zcrx: set pp memory provider for an rx queue David Wei
2024-12-04 17:21 ` [PATCH net-next v8 14/17] io_uring/zcrx: add copy fallback David Wei
2024-12-04 17:21 ` [PATCH net-next v8 15/17] io_uring/zcrx: throttle receive requests David Wei
2024-12-04 17:21 ` [PATCH net-next v8 16/17] net: add documentation for io_uring zcrx David Wei
2024-12-09 17:51 ` Mina Almasry
2024-12-10 16:53 ` David Wei
2024-12-09 17:52 ` Mina Almasry
2024-12-10 16:54 ` David Wei
2024-12-04 17:21 ` [PATCH net-next v8 17/17] io_uring/zcrx: add selftest David Wei
2024-12-04 18:59 ` [PATCH net-next v8 00/17] io_uring zero copy rx Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e1d368c-5a52-421c-9022-57166a8a3340@gmail.com \
--to=asml.silence@gmail$(echo .)com \
--cc=almasrymina@google$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=dw@davidwei$(echo .)uk \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=io-uring@vger$(echo .)kernel.org \
--cc=jdamato@fastly$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pctammela@mojatatu$(echo .)com \
--cc=stfomichev@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox