Subject: Re: [PATCH] netdev_ops

From: "David S. Miller" <[email-masked]>
Date: Tue, 08 Jul 2003 15:08:35 -0700 (PDT)

From: Matthew Wilcox <[email-masked]>
   Date: Tue, 8 Jul 2003 22:25:51 +0100

   On Tue, Jul 08, 2003 at 01:44:32PM -0700, Ben Greear wrote:
   > Some of these are missing their netdevice arg?
   > >+	int	(*get_regs_len)(struct ethtool_regs *);
   > >+	int	(*self_test_len)(struct ethtool_test *);
   > >+	int	(*get_strings_len)(struct ethtool_gstrings *);
   > >+	int	(*get_stats_len)(struct ethtool_stats *);
   
   Well, they don't actually need it -- these are more attributes of
   the underlying driver than they are of any individual network device.

Not true, at least for the regs len different variants of the same
chip can have a different sized register set.