Subject: Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting

From: "David S. Miller" <[email-masked]>
Date: Sat, 12 Jul 2003 22:34:49 -0700

On Sun, 13 Jul 2003 11:17:35 +1000 (EST)
James Morris <[email-masked]> wrote:

> On Fri, 11 Jul 2003, David S. Miller wrote:
> 
> > Oops, turns out this doesn't work.  data_ready is never NULL, look at
> > how netlink_kernel_create() works.
> 
> It's ok: sk->data_ready is never null, but nlk_sk(sk)->data_ready will be 
> null unless an input function is provided there.
> 
> > Also, the broadcast case probably needs to be handled
> > too?
> 
> Netlink sockets created by netlink_kernel_create() do not subscribe to any 
> groups and are not broadcast to.

Oops, you're right on both counts, I brainfarted here.

I'll apply your original patch, thanks.