Subject: Re: [PATCH] ethtool_ops rev 4

From: "David S. Miller" <[email-masked]>
Date: Sat, 2 Aug 2003 17:28:07 -0700

On Sat, 02 Aug 2003 18:34:46 -0400
Jeff Garzik <[email-masked]> wrote:

> Matthew Wilcox wrote:
> > +static inline void set_ethtool_ops(struct net_device *dev, struct ethtool_ops *
> > ops)
> > +{
> > +       dev->ethtool_ops = ops;
> > +}
> 
> 
> It needs to be a macro for maximum flexibility.

Yes, and please name it with capitol letters, ie.
SET_ETHTOOL_OPS(), I have no idea why you used
lower-case letters when Jeff and I referred to it
consistently with caps. :-)