From: Jeff Garzik <jgarzik@pobox•com>
To: Linus Torvalds <torvalds@osdl•org>
Cc: Stephen Hemminger <shemminger@osdl•org>, netdev@oss•sgi.com
Subject: Re: [PATCH] sdla non-module build fix.
Date: Mon, 8 Sep 2003 13:36:44 -0400 [thread overview]
Message-ID: <20030908173644.GA22629@gtf.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0309081030310.15082-100000@home.osdl.org>
On Mon, Sep 08, 2003 at 10:32:26AM -0700, Linus Torvalds wrote:
>
> On Mon, 8 Sep 2003, Stephen Hemminger wrote:
> >
> > Last round of changes broke sdla build if not a module.
>
> This patch can't be right. It may fix the compile, but it looks like
> init/exit_sdla is never registered at all if it's built-in.
>
> I suspect the whole #ifdef should go away. A driver that does things
> differently depending on whether it is a module or not is generally a
> _broken_ driver.
Nope, this is one of those weird two-ways-of-initialization things, like
drivers/net/Space.c or drivers/video/fbmem.c. If you look at the sdla
code, just above where Stephen's patch's context ends, you see
"sdla_init" which is called by both modular and non-modular code.
So -- with the exception of #ifdef'ing out MODULE_LICENSE, Stephen's
patch is ok.
Now that said, this situation is only temporary, until we get all the
network device structs being allocated dynamically, and interface
ordering issues are resolved. Once that happens, you are absolutely
right: sdla's #ifdef MODULE should be removed.
Jeff
prev parent reply other threads:[~2003-09-08 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44.0309071117290.21192-200000@home.osdl.org>
[not found] ` <3F5B7ED7.2070908@pobox.com>
2003-09-08 16:57 ` [PATCH] sdla non-module build fix Stephen Hemminger
2003-09-08 17:32 ` Linus Torvalds
2003-09-08 17:33 ` Stephen Hemminger
2003-09-08 17:36 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030908173644.GA22629@gtf.org \
--to=jgarzik@pobox$(echo .)com \
--cc=netdev@oss$(echo .)sgi.com \
--cc=shemminger@osdl$(echo .)org \
--cc=torvalds@osdl$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox