From: "David S. Miller" <davem@redhat•com>
To: chas3@users•sourceforge.net
Cc: chas@cmf•nrl.navy.mil, netdev@oss•sgi.com
Subject: Re: [RFC][0/2] remove atm_find_ci(); convert vcc_sklist to hash
Date: Wed, 8 Oct 2003 06:58:44 -0700 [thread overview]
Message-ID: <20031008065844.48fb53ae.davem@redhat.com> (raw)
In-Reply-To: <200310081246.h98CkPkT028970@ginger.cmf.nrl.navy.mil>
On Wed, 08 Oct 2003 08:46:26 -0400
chas williams <chas@cmf•nrl.navy.mil> wrote:
> the following two patches (which should be applied to a current 2.6 tree)
> obseletes atm_find_ci() which races the vpi/vci allocation (since the
> actual allocation is delayed until after the entering the drivers open()
> routine). all drivers now use the built-in find_ci(). to address
> performance issues the second patch converts the vcc_sklist to a hash
> based on the lower 5 bits in the vci.
These changes look fine, I'll add them to my tree.
> should this be tunable via config?
I don't think so, at least not now. My advice is, keep it a constant
for now and if people run into perf problems and the hash table size
is determined to be the cause you can investigate how to choose
different hash table sizes.
This is exactly what we did with the TCP hashes.
prev parent reply other threads:[~2003-10-08 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 12:46 [RFC][0/2] remove atm_find_ci(); convert vcc_sklist to hash chas williams
2003-10-08 13:58 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031008065844.48fb53ae.davem@redhat.com \
--to=davem@redhat$(echo .)com \
--cc=chas3@users$(echo .)sourceforge.net \
--cc=chas@cmf$(echo .)nrl.navy.mil \
--cc=netdev@oss$(echo .)sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox