public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat•com>
To: Ben Greear <greearb@candelatech•com>
Cc: vlan@wanfear•com, tommy.christensen@tpack•net,
	netdev@oss•sgi.com, bridge@osdl•org
Subject: Re: [Bridge] RE: [VLAN] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged{I,AR}P packets
Date: Wed, 8 Oct 2003 09:33:54 -0700	[thread overview]
Message-ID: <20031008093354.265b34a5.davem@redhat.com> (raw)
In-Reply-To: <3F843C8C.4030100@candelatech.com>

On Wed, 08 Oct 2003 09:34:20 -0700
Ben Greear <greearb@candelatech•com> wrote:

> So, what good is skb_share_check then?
> Maybe we should have a skb_share_or_cloned_check() ?

What input handlers are supposed to do is first:

	skb = skb_share_check(...);


then look at packet contents etc., then if they need to write
to the header do something like skb_cow().

The best example, as usual, is ipv4 input.  Look at how ip_rcv()
makes sure it can safely get at the packet header parts it needs
to parse, then look at ip_forward and how it cows the IPV4 header
so it can modify the TTL field.

  reply	other threads:[~2003-10-08 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-08  8:18 [Bridge] RE: [VLAN] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged{I,AR}P packets Christian Darnell
2003-10-08 16:34 ` Ben Greear
2003-10-08 16:33   ` David S. Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-10-07  9:06 Re: [PATCH/RFC] Let {ip,arp}tables " Christian Darnell
2003-10-08  8:09 ` [Bridge] RE: [VLAN] Re: [PATCH/RFC] Let {ip, arp}tables " Tommy Christensen
2003-10-08 15:58   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031008093354.265b34a5.davem@redhat.com \
    --to=davem@redhat$(echo .)com \
    --cc=bridge@osdl$(echo .)org \
    --cc=greearb@candelatech$(echo .)com \
    --cc=netdev@oss$(echo .)sgi.com \
    --cc=tommy.christensen@tpack$(echo .)net \
    --cc=vlan@wanfear$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox