From: Anton Blanchard <anton@samba•org>
To: "David S. Miller" <davem@redhat•com>
Cc: netdev@oss•sgi.com
Subject: Re: Allow IP header alignment to be overriden
Date: Sat, 12 Jun 2004 00:08:43 +1000 [thread overview]
Message-ID: <20040611140843.GD27672@krispykreme> (raw)
In-Reply-To: <20040610223549.5e9ad025.davem@redhat.com>
> This transformation is not valid for a lot of drivers, that "2"
> in the reserve exists elsewhere in other calculations in the
> drivers. For example, it is added to the RX skb allocation
> size. Sometimes this '2' is there in non-trivial or hard to
> see ways (ie. it's implicitly in some DMA alignment value)
>
> That's the only reason I'm against this patch.
Yeah I started converting all drivers across to skb_align and quickly
noticed that. We can instead convert drivers over as they are tested,
the Gbit and 10Gbit cards being the most important.
Ive tested the 2 10Gbit cards and one 1Gbit (e1000). I can test the
acenic and should be able to hunt down a sungem and tg3.
That leaves dl2K, myricom, ns83820, hamachi, yellowfin, r8169, and sk98lin
which can be converted across as needed.
Anton
prev parent reply other threads:[~2004-06-11 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-11 1:27 Allow IP header alignment to be overriden Anton Blanchard
2004-06-11 1:35 ` Andi Kleen
2004-06-11 1:43 ` Anton Blanchard
2004-06-11 5:35 ` David S. Miller
2004-06-11 7:39 ` Scott Feldman
2004-06-11 14:23 ` Anton Blanchard
2004-06-12 18:12 ` David S. Miller
2004-06-15 23:34 ` Anton Blanchard
2004-06-16 4:37 ` David S. Miller
2004-06-11 12:41 ` jamal
2004-06-11 14:08 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040611140843.GD27672@krispykreme \
--to=anton@samba$(echo .)org \
--cc=davem@redhat$(echo .)com \
--cc=netdev@oss$(echo .)sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox