Subject: Re: [PATCH] LLTX for tg3

From: "David S. Miller" <[email-masked]>
Date: Sun, 12 Sep 2004 16:45:16 -0700

On Sun, 12 Sep 2004 19:06:26 +0200
Eric Lemoine <[email-masked]> wrote:

> > Add LLTX suppor to tg3.  Locking was already safe for it, so only
> > trivial changes.
> 
> tg3_set_rx_mode() (dev->set_multicast_list()) and tg3_start_xmit()
> used to synchronise thanks to dev->lock_xmit. With your LLTX patches
> they don't synchronise anymore (I don't think tg3_set_rx_mode() grabs
> tp->tx_lock) ; isn't it an issue?

You're absolutely right, I've made tg3_set_rx_mode() grab the
tx_lock now too.

Good spotting Eric.