Subject: Re: [PATCH] Make netif_rx_ni preempt-safe

From: "David S. Miller" <[email-masked]>
Date: Wed, 20 Oct 2004 21:58:40 -0700

On Thu, 21 Oct 2004 10:35:03 +1000
Herbert Xu <[email-masked]> wrote:

> On Wed, Oct 20, 2004 at 05:15:08PM -0700, David S. Miller wrote:
> >  
> > +int netif_rx_ni(struct sk_buff *skb)
> > +{
> > +       int err = netif_rx(skb);
> > +
> > +       preempt_disable();
> > +       if (softirq_pending(smp_processor_id()))
> > +               do_softirq();
> 
> You need to move the netif_rx call inside the disable as otherwise
> you might be checking the pending flag on the wrong CPU.

Good catch, I've made that fix in my tree.

Thanks.