Subject: Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used

From: "David S. Miller" <[email-masked]>
Date: Tue, 26 Oct 2004 17:03:44 -0700

On Wed, 27 Oct 2004 10:07:24 +1000
Herbert Xu <[email-masked]> wrote:

> On Tue, Oct 26, 2004 at 07:54:35PM -0400, Jeff Garzik wrote:
> > Herbert Xu wrote:
> > >+static int __ethtool_set_sg(struct net_device *dev, u32 data)
> > >+{
> > >+	int err;
> > >+
> > >+	if (!data && dev->ethtool_ops->set_tso) {
> > >+		err = dev->ethtool_ops->set_tso(dev, 0);
> > >+		if (err)
> > >+			return err;
> > >+	}
> > >+
> > >+	return dev->ethtool_ops->set_sg(dev, data);
> > >+}
> > 
> > you want to disable tx-csum also
> 
> IMHO it is valid to disable SG without disabling checksums, no?

Yes and no.  SG support requires TX csum support.  See the tests we
make at register_netdev() time.

So as long as you enforce that rule, which I believe you are,
things are fine.