Subject: Re: [patch 8/9] AES: allow modular build

From: Christoph Hellwig <[email-masked]>
Date: Thu, 28 Oct 2004 10:04:31 +0100

On Thu, Oct 28, 2004 at 12:19:47AM -0700, [email-masked] wrote:
> 
> From: <[email-masked]>
> 
> 
> Signed-off-by: Andrew Morton <[email-masked]>
> ---
> 
>  25-akpm/arch/i386/crypto/Makefile |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN arch/i386/crypto/Makefile~aes-allow-modular-build arch/i386/crypto/Makefile
> --- 25/arch/i386/crypto/Makefile~aes-allow-modular-build	2004-10-28 00:17:08.598496816 -0700
> +++ 25-akpm/arch/i386/crypto/Makefile	2004-10-28 00:17:08.603496056 -0700
> @@ -6,4 +6,4 @@
>  
>  obj-$(CONFIG_CRYPTO_AES_586) += aes-i586.o
>  
> -aes-i586-y := aes-i586-asm.o aes.o
> +aes-i586-objs := aes-i586-asm.o aes.o

This doesn't make any sense to me.

foo-objs and foo-y are treated equivalent by the build system, and not
related to modular builds at all.  In fact -y is preffered these days
as it allows to build parts of the multi-object module conditionally using
expressions like:

  foo-y			+= foo_main.o
  foo-$(CONFIG_FOO_BAR) += foo_bar.o