Subject: Re: [patch 05/18] net/s2io: replace schedule_timeout() with msleep()

From: Nishanth Aravamudan <[email-masked]>
Date: Mon, 1 Nov 2004 11:14:50 -0800

On Mon, Nov 01, 2004 at 01:03:10PM -0500, Jeff Garzik wrote:
> Nishanth Aravamudan wrote:
> >On Sun, Oct 31, 2004 at 06:09:34AM -0500, Jeff Garzik wrote:
> >
> >>[email-masked] wrote:
> >>
> >>>@@ -2846,11 +2838,10 @@ static int s2io_ethtool_idnic(struct net
> >>>		sp->id_timer.data = (unsigned long) sp;
> >>>	}
> >>>	mod_timer(&sp->id_timer, jiffies);
> >>>-	set_current_state(TASK_INTERRUPTIBLE);
> >>>	if (data)
> >>>-		schedule_timeout(data * HZ);
> >>>+		msleep_interruptible(data * 1000);
> >>
> >>
> >>clearly wants ssleep() here
> >
> >
> >Even though ssleep() is in TASK_UNINTERRUPTIBLE? In cases where the
> >existing code used TASK_INTERRUPTIBLE, but was sleeping in terms of
> >seconds, I left it as msleep_interruptible, since ssleep_interruptible()
> >doesn't exist.
> 
> Right:  create ssleep_interruptible()  :)

Ok, will do :) I wasn't sure by your e-mail whether you meant to use
ssleep() or create ssleep_interruptible(). Patch will follow shortly.

-Nish