Subject: Re: [NET] Move local_bh_disable back in dev_queue_xmit

From: "David S. Miller" <[email-masked]>
Date: Wed, 3 Nov 2004 12:50:30 -0800

On Wed, 03 Nov 2004 15:48:49 +0100
Tommy Christensen <[email-masked]> wrote:

> Herbert Xu wrote:
> > Hi Ingo:
> > 
> > Your recent fix to dev_queue_xmit moved the local_bh_disable to
> > include stuff like skb_linearize and skb_checksum_help.  These
> > are potentially expensive operations.  Since they don't need to
> > run with preempt off, we could simply move the local_bh_enable
> > up instead.
> 
> No, this breaks the normal return path.
> 
> How about this instead?

Yep, this one is better.  Patch applied, thanks everyone.