Subject: Re: net/ne2k-pci: module_param conversion

From: Domen Puncer <[email-masked]>
Date: Wed, 24 Nov 2004 21:43:48 +0100

On 24/11/04 15:05 -0500, Jeff Garzik wrote:
> [email-masked] wrote:
> >@@ -443,8 +435,7 @@ static void ne2k_pci_reset_8390(struct n
> > {
> > 	unsigned long reset_start_time = jiffies;
> > 
> >-	if (debug > 1) printk("%s: Resetting the 8390 t=%ld...",
> >-						  dev->name, jiffies);
> >+	printk(KERN_INFO "%s: Resetting the 8390 t=%ld...", dev->name, 
> >jiffies);
> 
> 
> The rest of the patch looks OK.
> 
> This chunk changes behavior, by removing the 'if' test.

This was intended.
Module parameter debug is only used in this test, so i dared removing it.
3 options:
- remove this printk
- don't remove "debug"
- leave patch as is :-)

Let me know of your decision, and i'll send a new patch.
> 	Jeff