Subject: Re: [2.6 patch] net/ipv4/: misc possible cleanups

From: Adrian Bunk <[email-masked]>
Date: Tue, 28 Dec 2004 04:36:17 +0100

On Mon, Dec 27, 2004 at 07:15:35PM -0800, David S. Miller wrote:
> On Wed, 15 Dec 2004 01:51:39 +0100
> Adrian Bunk <[email-masked]> wrote:
> 
> > - remove the following unneeded EXPORT_SYMBOL:
> >   - tcp_timer.c: tcp_timer_bug_msg
> 
> This one is wrong.  It is needed for the ipv6 module
> via the call tcp_ipv6.c makes to tcp_done() which
> invokes tcp_clear_xmit_timer() which uses
> tcp_timer_bug_msg.

tcp_done doesn't call tcp_clear_xmit_timer, it calls 
tcp_clear_xmit_timers (note the s) which is not an inline but an 
EXPORT_SYMBOL'ed function in tcp_timer.c.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed