From: Nishanth Aravamudan <nacc@us•ibm.com>
To: kernel-janitors@lists•osdl.org
Cc: linux-net@vger•kernel.org, netdev@oss•sgi.com
Subject: [KJ] [PATCH 5/28] net/cs89x0: replace schedule_timeout() with msleep()
Date: Thu, 6 Jan 2005 16:14:53 -0800 [thread overview]
Message-ID: <20050107001453.GF3055@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
Hi,
Description: The existing wait is in TASK_INTERRUPTIBLE, but does not check for
signals (especially problemtic for a 30 msec wait!) as being a cause for
schedule_timeout()s return. Use msleep() instead, to guarantee the task delays
as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us•ibm.com>
--- 2.6.10-v/drivers/net/cs89x0.c 2004-12-24 13:35:24.000000000 -0800
+++ 2.6.10/drivers/net/cs89x0.c 2005-01-04 14:57:49.000000000 -0800
@@ -136,6 +136,7 @@
#include <linux/string.h>
#include <linux/init.h>
#include <linux/bitops.h>
+#include <linux/delay.h>
#include <asm/system.h>
#include <asm/io.h>
@@ -909,8 +910,7 @@ void __init reset_chip(struct net_devic
writereg(dev, PP_SelfCTL, readreg(dev, PP_SelfCTL) | POWER_ON_RESET);
/* wait 30 ms */
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(30*HZ/1000);
+ msleep(30);
#ifndef CONFIG_ARCH_IXDP2X01
if (lp->chip_type != CS8900) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists•osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2005-01-07 0:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050107001453.GF3055@us.ibm.com \
--to=nacc@us$(echo .)ibm.com \
--cc=kernel-janitors@lists$(echo .)osdl.org \
--cc=linux-net@vger$(echo .)kernel.org \
--cc=netdev@oss$(echo .)sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox