Subject: Re: [patch 1/1] net/pcnet32: replace schedule_timeout() with msleep_interruptible()

From: Don Fry <[email-masked]>
Date: Tue, 11 Jan 2005 16:04:58 -0800

Looks and runs fine.

Signed-off-by: Don Fry <[email-masked]>

On Wed, Jan 12, 2005 at 12:01:49AM +0100, [email-masked] wrote:
> 
> 
> 
> Any comments would be appreciated.
> 
> Description: Use msleep_interruptible() instead of schedule_timeout() to
> guarantee the task delays as expected.
> 
> Signed-off-by: Nishanth Aravamudan <[email-masked]>
> Signed-off-by: Maximilian Attems <[email-masked]>
> Signed-off-by: Domen Puncer <[email-masked]>
> ---
> 
> 
>  kj-domen/drivers/net/pcnet32.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/net/pcnet32.c~msleep_interruptible-drivers_net_pcnet32 drivers/net/pcnet32.c
> --- kj/drivers/net/pcnet32.c~msleep_interruptible-drivers_net_pcnet32	2005-01-10 18:00:07.000000000 +0100
> +++ kj-domen/drivers/net/pcnet32.c	2005-01-10 18:00:07.000000000 +0100
> @@ -847,7 +847,7 @@ static int pcnet32_phys_id(struct net_de
>      if ((!data) || (data > (u32)(MAX_SCHEDULE_TIMEOUT / HZ)))
>      data = (u32)(MAX_SCHEDULE_TIMEOUT / HZ);
>  
> -    schedule_timeout(data * HZ);
> +    msleep_interruptible(data * 1000);
>      del_timer_sync(&lp->blink_timer);
>  
>      /* Restore the original value of the bcrs */
> _
> 
> 

-- 
Don Fry
[email-masked]