Subject: Re: Fwd: [2.6] ethertap and af_inet.c assertion failures

From: "David S. Miller" <[email-masked]>
Date: Mon, 17 Jan 2005 13:37:51 -0800

On Sun, 16 Jan 2005 00:31:46 +1100
Herbert Xu <[email-masked]> wrote:

> Tommy Christensen <[email-masked]> wrote:
> > 
> > netlink has messed up the send buffer accounting, when trimming a skb.
> 
> You are spot on.  Dave, you were right too about checking for charged
> skb's in netlink_trim.

It's good to know that I'm legitimately paranoid from time to
time :-)

> Since the skb will be orphaned on its way to the destination anyway,
> let's simply do that before the trimming.  This shouldn't lead to
> skb leakage since the skb will either be charged to the destination
> socket or freed.
> 
> Signed-off-by: Herbert Xu <[email-masked]>

Looks good, I'll apply this.

Thanks Herbert.