Subject: Re: [PATCH]: was Re: LLTX and netif_stop_queue

From: "David S. Miller" <[email-masked]>
Date: Wed, 19 Jan 2005 21:18:35 -0800

On 19 Jan 2005 23:01:47 -0500
jamal <[email-masked]> wrote:

> -----
> /* Called with dev->xmit_lock held and interrupts disabled.  */
>  static int
>  e1000_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
> ---
> 
> Who calls that with dev->xmit_lock held and interrupts disabled?

qdisc_restart() and dev_queue_xmit(), via netdev->hard_start_xmit().

> Shouldnt the spin_unlock(&netdev->xmit_lock); be right at the top of
> that routine now?

Nope, the idea now is that netdev->xmit_lock replaces the driver
private tx_lock