Subject: Re: [PATCH 2.6.10] tg3: add tg3_set_eeprom

From: "David S. Miller" <[email-masked]>
Date: Thu, 20 Jan 2005 15:05:19 -0800

On Thu, 20 Jan 2005 14:52:14 -0800
"Michael Chan" <[email-masked]> wrote:

> Add tg3_set_eeprom routine to support configuration changes (e.g. ASF
> config).
> 
> Made changes to other nvram related routines.

Why were the NVRAM_ACCESS writes change to non-flushing register
writes?  Otherwise I think your patch is fine.

Maybe it would be nice if you provided a detailed changelog
of sorts, because other's might have similar questions like I
did about why the tw32_f() --> tw32() changes were made.