Subject: Re: [RFC 2.6.10 2/22] xfrm: Add xfrm offload management calls to struct netdevice

From: "David S. Miller" <[email-masked]>
Date: Fri, 21 Jan 2005 14:40:45 -0800

On Thu, 30 Dec 2004 03:48:34 -0500
David Dillow <[email-masked]> wrote:

> # This is a BitKeeper generated diff -Nru style patch.
> #
> # ChangeSet
> #   2004/12/30 00:28:25-05:00 [email-masked] 
> #   Add the xfrm offload management calls to struct netdevice.
> #   
> #   xfrm_state_add() is called for inbound xfrm states
> #   xfrm_bundle_add() is called for outbound xfrm bundles
> #   xfrm_state_del() is called for all offloaded xfrms,
> #   	inbound or outbound.
> #   
> #   If a driver adds NETIF_F_IPSEC to its features, it must
> #   provide all three callbacks.
> #   
> #   Signed-off-by: David Dillow <[email-masked]>

I have no problems with this interface.  In fact, just about
whatever works for the card you have would be fine for an
initial implementation.

We know this interface will likely need to change over time
so we should explicitly mark these callbacks as in a state
of flux so that nobody who tries to play with this gets surprised
when we tweak it.