Subject: Re: [PATCH 2.6]: keep fragment queues private to each user

From: "David S. Miller" <[email-masked]>
Date: Tue, 25 Jan 2005 21:41:58 -0800

On Tue, 25 Jan 2005 05:57:47 +0100
Patrick McHardy <[email-masked]> wrote:

> This patch keeps fragment queues private to each ip_defrag user to avoid
> skbs jumping between different callers. It shouldn't change any wanted
> behaviour, the only questionable one was ip_call_ra_chain, but the RA
> option is included in each fragment. If you're fine with the patch I'm going
> to send a 2.4 version later.

Please fix the CONFIG_SMP build.  You use some variable "user"
in ip_frag_intern(), yet don't add this as an argument or
anything like that.

The "user" use you added is protected by CONFIG_SMP, so my guess
is that you compile and tested this without SMP enabled.