Subject: Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

From: Adrian Bunk <[email-masked]>
Date: Wed, 2 Mar 2005 23:45:50 +0100

On Wed, Mar 02, 2005 at 05:41:50PM -0500, Jeff Garzik wrote:
> Andrew Morton wrote:
> >Jeff Garzik <[email-masked]> wrote:
> >
> >>>Thing is, CRYPTO_AES on only selectable on x86.
> >>
> >>You're thinking about CRYPTO_AES_586.  But looking at crypto/Kconfig, 
> >>the dependencies are a bit weird:
> >>
> >>config CRYPTO_AES
> >>         tristate "AES cipher algorithms"
> >>         depends on CRYPTO && !(X86 && !X86_64)
> >>config CRYPTO_AES_586
> >>         tristate "AES cipher algorithms (i586)"
> >>         depends on CRYPTO && (X86 && !X86_64)
> >
> >
> >That's pretty broken, isn't it?
> >
> >Would be better to just do:
> >
> >config CRYPTO_AES
> >	select CRYPTO_AES_586 if (X86 && !X86_64)
> >	select CRYPTO_AES_OTHER if !(X86 && !X86_64)
> >
> >and hide CRYPTO_AES_586 and CRYPTO_AES_OTHER from the outside world.
> 
> Not really that easy.  For x86 we have
> 
> 	aes
> 	aes-586
> 	aes-via

Where is aes-via?

> And my own personal custom-kernel preference is to use the C version of 
> the code on my x86 and x86-64 boxes.

That's already not possible today.

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed