Subject: Re: [PATCH 3/3] SGI Altix cross partition functionality (2nd revision)

From: "David S. Miller" <[email-masked]>
Date: Wed, 23 Mar 2005 12:02:48 -0800

On Wed, 23 Mar 2005 13:51:39 -0600
Dean Nelson <[email-masked]> wrote:

> This patch contains the cross partition pseudo-ethernet driver (XPNET)
> functional support module.
> 
> Signed-off-by: Dean Nelson <[email-masked]>

Only a NIT or two.  You should be setting the last_rx
value.  Also, NETIF_F_HIGHDMA is pointless unless you
support NETIF_F_SG and thus paged SKBs.  skb->data will
never be placed in high memory, only non-linear SKB
scatterlist pages will.

I should probably add a debugging check at device
registration time, like we already do to make sure
NETIF_F_SG is not set unless some checksumming
capability is there as well.