From: Greg KH <greg@kroah•com>
To: Francois Romieu <romieu@fr•zoreil.com>
Cc: Greg KH <gregkh@suse•de>,
torvalds@osdl•org, akpm@osdl•org, "Theodore Ts'o" <tytso@mit•edu>,
Zwane Mwaikambo <zwane@arm•linux.org.uk>,
netdev@vger•kernel.org, Justin Forbes <jmforbes@linuxtx•org>,
linux-kernel@vger•kernel.org, ralf@linux-mips•org,
"Randy.Dunlap" <rdunlap@xenotime•net>,
Chuck Wolber <chuckw@quantumlinux•com>,
jgarzik@pobox•com, stable@kernel•org, alan@lxorguk•ukuu.org.uk
Subject: Re: [stable] Re: [05/11] SMP fix for 6pack driver
Date: Wed, 13 Jul 2005 15:13:11 -0700 [thread overview]
Message-ID: <20050713221311.GA30039@kroah.com> (raw)
In-Reply-To: <20050713220123.GA3292@electric-eye.fr.zoreil.com>
On Thu, Jul 14, 2005 at 12:01:23AM +0200, Francois Romieu wrote:
> Greg KH <gregkh@suse•de> :
> > -stable review patch. If anyone has any objections, please let us know.
> >
> > ------------------
> >
> >
> > Drivers really only work well in SMP if they actually can be selected.
> > This is a leftover from the time when the 6pack drive only used to be
> > a bitrotten variant of the slip driver.
>
> Is the guideline above from 28/04/2005 obsoleted ?
>
> - It must fix a problem that causes a build error (but not for things
> marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
> security issue, or some "oh, that's not good" issue. In short,
> something critical.
It lets the driver be built, when it previously could not be, unless the
user used a config option that almost no one does...
That's pretty critical if you ask me.
thanks,
greg k-h
next prev parent reply other threads:[~2005-07-13 22:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050713184130.GA9330@kroah.com>
2005-07-13 18:43 ` [05/11] SMP fix for 6pack driver Greg KH
2005-07-13 22:01 ` Francois Romieu
2005-07-13 22:13 ` Greg KH [this message]
2005-07-15 19:35 ` [stable] " Adrian Bunk
2005-07-17 21:09 ` Ralf Baechle
2005-07-24 16:08 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050713221311.GA30039@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=akpm@osdl$(echo .)org \
--cc=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=chuckw@quantumlinux$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=jgarzik@pobox$(echo .)com \
--cc=jmforbes@linuxtx$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ralf@linux-mips$(echo .)org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=romieu@fr$(echo .)zoreil.com \
--cc=stable@kernel$(echo .)org \
--cc=torvalds@osdl$(echo .)org \
--cc=tytso@mit$(echo .)edu \
--cc=zwane@arm$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox