Subject: Re: [RFC][PATCH 3/3] TCP/IP Critical socket communication mechanism

From: Ingo Oeser <[email-masked]>
Date: Wed, 14 Dec 2005 14:18:48 +0100

Mitchell Blank Jr wrote:
> Alan Cox wrote:
> > > +#define SK_CRIT_ALLOC(sk, flags) ((sk->sk_allocation & __GFP_CRITICAL) | flags)
> > 
> > Lots of hidden conditional logic on critical paths.
> 
> How expensive is it compared to the allocation itself?

Cost is readability here. You should open code this additional OR

Regards

Ingo Oeser