Subject: bcm43xx_sysfs.c: strange code

From: Adrian Bunk <[email-masked]>
Date: Tue, 4 Apr 2006 20:44:35 +0200

The Coverity checker spotted the following strange code:

<--  snip  -->

static ssize_t bcm43xx_attr_interfmode_show(struct device *dev,
                                            struct device_attribute *attr,
                                            char *buf)
{
...
        err = 0;

        bcm43xx_unlock(bcm, flags);

        return err ? err : count;

}
...
static ssize_t bcm43xx_attr_preamble_show(struct device *dev,
                                          struct device_attribute *attr,
                                          char *buf)
{
...
        err = 0;
        bcm43xx_unlock(bcm, flags);

        return err ? err : count;
}
...
static ssize_t bcm43xx_attr_preamble_store(struct device *dev,
                                           struct device_attribute *attr,
                                           const char *buf, size_t count)
{
...
        err = 0;
        bcm43xx_unlock(bcm, flags);

        return err ? err : count;
}
...

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed