Subject: Re: [PATCH]: suspicious unlikely usage in tcp_transmit_skb()

From: Stephen Hemminger <[email-masked]>
Date: Tue, 25 Apr 2006 15:16:35 -0700

On Tue, 25 Apr 2006 14:46:49 -0700 (PDT)
"David S. Miller" <[email-masked]> wrote:

> From: Stephen Hemminger <[email-masked]>
> Date: Tue, 25 Apr 2006 10:01:49 -0700
> 
> > >       # Hit    # miss Function:Filename@Line
> > > !         0     50505 tcp_transmit_skb():net/ipv4/tcp_output.c@468
>  ...
> > How about just taking off the likely/unlikely in this case.
> 
> Why remove it when we'll now get a 50505 to 0 hit rate?

Depends on the data stream, but I guess if we are seeing high loss
we really don't care about the CPU branch prediction.