Subject: Re: [PATCH 3/32] rt2x00: use pci_*_consistent for DMA mapping

From: Ivo van Doorn <[email-masked]>
Date: Fri, 28 Apr 2006 14:57:31 +0200

On Friday 28 April 2006 00:11, Christoph Hellwig wrote:
> On Fri, Apr 28, 2006 at 12:02:52AM +0200, Ivo van Doorn wrote:
> > From: Ivo van Doorn <[email-masked]>
> > 
> > Instead of dma_*_coherent
> > use pci_*consistent functions.
> 
> No point in doing that, quite reverse as you use the gfp_mask argument
> which is a (small) pessimation here.

Would it be recommended that I replace the usb_alloc_buffers in the
rt2570 driver with dma_*coherent?
This would get the dma rings allocation and freeing a bit more generic
between PCI and USB and could reduce some duplicate code between them.
But I am not sure if there is any major difference between the two.