Subject: Re: [PATCH] irda-usb: use NULL instead of 0

From: Ivo van Doorn <[email-masked]>
Date: Tue, 2 May 2006 00:19:20 +0200

On Tuesday 2 May 2006 00:08, Randy.Dunlap wrote:
> From: Randy Dunlap <[email-masked]>
> 
> Use NULL instead of 0 for a null pointer value (sparse warning):
> drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Randy Dunlap <[email-masked]>
> ---
>  drivers/net/irda/irda-usb.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2617-rc3.orig/drivers/net/irda/irda-usb.c
> +++ linux-2617-rc3/drivers/net/irda/irda-usb.c
> @@ -1778,7 +1778,7 @@ static int irda_usb_probe(struct usb_int
>  
>  	if (self->needspatch) {
>  		ret = usb_control_msg (self->usbdev, usb_sndctrlpipe (self->usbdev, 0),
> -				       0x02, 0x40, 0, 0, 0, 0, msecs_to_jiffies(500));
> +				       0x02, 0x40, 0, 0, NULL, 0, msecs_to_jiffies(500));

I could be mistaken, but wasn't the usb_control_msg timeout type changed in kernel 2.6.12?
The timeout value is no longer in jiffies but in msecs.

>  		if (ret < 0) {
>  			IRDA_DEBUG (0, "usb_control_msg failed %d\n", ret);
>  			goto err_out_3;

IvD