public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl•org>
To: Baruch Even <baruch@ev-en•org>
Cc: #ZHOU BIN# <ZHOU0022@ntu•edu.sg>,
	jmorris@namei•org, netdev@vger•kernel.org
Subject: Re: [PATCH] TCP Veno module for kernel 2.6.16.13
Date: Wed, 24 May 2006 09:46:30 -0700	[thread overview]
Message-ID: <20060524094630.6fb7cdff@localhost.localdomain> (raw)
In-Reply-To: <447486F4.1050307@ev-en.org>

On Wed, 24 May 2006 17:16:52 +0100
Baruch Even <baruch@ev-en•org> wrote:

> #ZHOU BIN# wrote:
> > From: Bin Zhou <zhou0022@ntu•edu.sg>
> > +		else if (sysctl_tcp_abc) {
> > + 			/* RFC3465: Apppriate Byte Count
> > + 	 		* increase once for each full cwnd acked.
> > + 	 		* Veno has no idear about it so far, so we keep
> > + 	 		* it as Reno.
> > + 	 		*/
> > + 			if (tp->bytes_acked >= tp->snd_cwnd*tp->mss_cache) {
> > + 				tp->bytes_acked -= tp->snd_cwnd*tp->mss_cache;
> > + 				if (tp->snd_cwnd < tp->snd_cwnd_clamp)
> > + 					tp->snd_cwnd++;
> > + 			}
> 
> You should prefer to ignore abc instead. At least that's what everyone
> else is doing, the only place where abc is active is in NewReno.
> 
> Baruch

That was intentional. When ABC was added, the desire was to not change existing
behavior for other congestion control methods.

  reply	other threads:[~2006-05-24 16:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-24 11:08 [PATCH] TCP Veno module for kernel 2.6.16.13 #ZHOU BIN#
2006-05-24 15:04 ` Stephen Hemminger
2006-05-24 15:20   ` James Morris
2006-05-24 16:16 ` Baruch Even
2006-05-24 16:46   ` Stephen Hemminger [this message]
2006-05-28 22:22 ` Thomas Kho
  -- strict thread matches above, loose matches on Subject: below --
2006-05-25  8:30 #ZHOU BIN#
2006-05-25 20:23 ` David Miller
2006-05-25 20:50   ` Stephen Hemminger
2006-05-25 21:08     ` David Miller
2006-05-25 21:11 Caitlin Bestler
2006-05-25 21:59 ` David Miller
2006-05-26  6:32 Fu Cheng Peng, Franklin
2006-05-29  3:26 #ZHOU BIN#

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060524094630.6fb7cdff@localhost.localdomain \
    --to=shemminger@osdl$(echo .)org \
    --cc=ZHOU0022@ntu$(echo .)edu.sg \
    --cc=baruch@ev-en$(echo .)org \
    --cc=jmorris@namei$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox