Subject: Re: [PATCH 3/4] myri10ge - Driver core

From: Ingo Oeser <[email-masked]>
Date: Fri, 26 May 2006 11:49:18 +0200

Hi there,

Benjamin Herrenschmidt wrote:
> On Wed, 2006-05-24 at 01:39 +1000, Anton Blanchard wrote:
> 
> > > +#ifdef CONFIG_MTRR
> > > +	mgp->mtrr = mtrr_add(mgp->iomem_base, mgp->board_span,
> > > +			     MTRR_TYPE_WRCOMB, 1);
> > > +#endif
> > ...
> > > +	mgp->sram = ioremap(mgp->iomem_base, mgp->board_span);
> > 
> > Not sure how we are meant to specify write through in drivers. Any ideas Ben?
> 
> No proper interface exposed, he'll have to do an #ifdef powerpc here or
> such and use __ioremap with explicit page attributes. I have a hack to
> do that automatically for memory covered by prefetchable PCI BARs when
> mmap'ing from userland but not for kernel ioremap.

Stupid question: pci_iomap() is NOT what you are looking for, right?

Implementation is at the end of lib/iomap.c

Regards

Ingo Oeser