Subject: Re: [PATCH 2.6.18 2/3] tg3: Convert to non-LLTX

From: Stephen Hemminger <[email-masked]>
Date: Mon, 5 Jun 2006 17:31:59 -0700

On Mon, 05 Jun 2006 14:29:45 -0700
"Michael Chan" <[email-masked]> wrote:

> On Mon, 2006-06-05 at 15:58 -0700, Stephen Hemminger wrote:
> 
> > 
> > Since you are going more lockless, you probably need memory barriers.
> 
> No, we're not going more lockless. We're simply replacing the private
> tx_lock with dev->xmit_lock by dropping the LLTX feature flag. The
> amount of locking is exactly the same as before.

Those spin lock's were also acting as barriers.
Are you sure code is safe in the face of cpu reordering.

-- 
If one would give me six lines written by the hand of the most honest
man, I would find something in them to have him hanged. -- Cardinal Richlieu