Subject: Re: [PATCH 3/4] ehea: queue managment

From: Stephen Hemminger <[email-masked]>
Date: Wed, 7 Jun 2006 10:29:50 -0700

On Wed, 07 Jun 2006 19:05:02 +0200
Jan-Bernd Themann <[email-masked]> wrote:

> Signed-off-by:  Jan-Bernd Themann <[email-masked]>
> 
> 
> drivers/net/ehea/ehea_qmr.c |  719 ++++++++++++++++++++++++++++++++++++++++++++
> drivers/net/ehea/ehea_qmr.h |  390 +++++++++++++++++++++++
> 2 files changed, 1109 insertions(+)
> 

Make it look less like C++

Do you really need to use vmalloc/vfree? Are the data structures that big?

Be careful about global namespace issues. Stick to one prefix like ehea_
for all non static function names. Consider putting all in one file, or
use #include to cause it to be one compilation unit.