Subject: Re: [PATCH 1/9] NetXen 1G/10G ethernet driver patch with corrections

From: Andi Kleen <[email-masked]>
Date: Wed, 7 Jun 2006 11:49:51 +0200

On Wednesday 07 June 2006 11:39, Linsys Contractor Amit S. Kale wrote:

> +	switch (mode) {

... You could save a lot of code by using a table and a loop over the registers.

> +	case 4:{		/* XGB Mode */
> +			NETXEN_NIC_LOCKED_READ_REG(NETXEN_NIU_XG_SINGLE_TERM,
> +						   &regs_buff[3]);

-Andi