From: Matt Mackall <mpm@selenic•com>
To: Neil Horman <nhorman@tuxdriver•com>
Cc: Jeff Moyer <jmoyer@redhat•com>,
Auke Kok <auke-jan.h.kok@intel•com>,
"Garzik, Jeff" <jgarzik@pobox•com>,
Mitch Williams <mitch.a.williams@intel•com>,
netdev@vger•kernel.org, "Brandeburg,
Jesse" <jesse.brandeburg@intel•com>,
"Kok, Auke" <auke@foo-projects•org>
Subject: Re: [PATCH 1/2] e1000: fix netpoll with NAPI
Date: Wed, 7 Jun 2006 11:48:01 -0500 [thread overview]
Message-ID: <20060607164801.GX24227@waste.org> (raw)
In-Reply-To: <20060607150522.GA24608@hmsreliant.homelinux.net>
On Wed, Jun 07, 2006 at 11:05:22AM -0400, Neil Horman wrote:
> >
> > > Matt, any ideas on this?
> >
> > Not at the moment.
>
> how about this for a solution? It doesn't make netpoll any more robust, but I
> think in the interests of efficiency it would be fair to require that, when
> netpolled, a driver must receive frames on the same net device for which it was
> polled. With this patch we detect that condition and handle it accordingly in
> e1000_intr. This eliminates the need for us to call the clean_rx method from
> the poll_controller when napi is configured, instead allowing the poll method to
> be called from napi_poll, as the netpoll model currently does. This fixes the
> netdump regression, and eliminates the layering violation and the potential race
> that we've been discussing. I've just tested it with netdump here and it works
> quite well.
>
> Thoughts appreciated.
This looks pretty reasonable, mostly from the perspective that it
doesn't put any further ugliness in netpoll. We might want to add a
comment somewhere in netpoll of the new rule we're now observing.
I'll let the e1000 guys comment on the particulars of the driver change.
> Signed-off-by: Neil Horman <nhorman@tuxdriver•com>
Signed-off-by: Matt Mackall <mpm@selenic•com>
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2006-06-07 16:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 23:09 [PATCH 0/2] e1000: fixes for netpoll+NAPI, ARM Kok, Auke
2006-06-05 23:11 ` [PATCH 1/2] e1000: fix netpoll with NAPI Kok, Auke
2006-06-06 13:52 ` Neil Horman
2006-06-06 16:39 ` Mitch Williams
2006-06-06 17:05 ` Neil Horman
2006-06-06 17:18 ` Auke Kok
2006-06-06 17:30 ` Jeff Moyer
2006-06-06 17:34 ` Auke Kok
2006-06-06 17:42 ` Jeff Moyer
2006-06-06 23:17 ` Matt Mackall
2006-06-07 15:05 ` Neil Horman
2006-06-07 16:48 ` Matt Mackall [this message]
2006-06-07 18:25 ` Auke Kok
2006-06-07 18:44 ` Jeff Moyer
2006-06-07 19:18 ` Neil Horman
2006-06-08 17:19 ` Mitch Williams
2006-06-08 17:29 ` Jeff Moyer
2006-06-12 0:13 ` Neil Horman
2006-06-12 16:42 ` Mitch Williams
2006-06-12 18:06 ` Neil Horman
2006-06-14 20:41 ` Neil Horman
2006-06-14 23:44 ` Mitch Williams
2006-06-15 12:44 ` John W. Linville
2006-06-15 20:45 ` Mitch Williams
2006-06-20 8:28 ` Andrew Grover
2006-06-07 18:54 ` John W. Linville
2006-06-08 17:23 ` Mitch Williams
2006-06-08 18:39 ` John W. Linville
2006-06-06 17:29 ` Jeff Moyer
2006-06-05 23:11 ` [PATCH 2/2] e1000: remove risky prefetch on next_skb->data Kok, Auke
2006-06-05 23:21 ` Rick Jones
2006-06-06 0:12 ` Brandeburg, Jesse
2006-06-06 0:16 ` Rick Jones
2006-06-06 0:22 ` Andi Kleen
2006-06-06 0:26 ` Brandeburg, Jesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060607164801.GX24227@waste.org \
--to=mpm@selenic$(echo .)com \
--cc=auke-jan.h.kok@intel$(echo .)com \
--cc=auke@foo-projects$(echo .)org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jgarzik@pobox$(echo .)com \
--cc=jmoyer@redhat$(echo .)com \
--cc=mitch.a.williams@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox