Subject: Re: [RFC] [patch 2/6] [Network namespace] Network device sharing by view

From: Al Viro <[email-masked]>
Date: Sun, 18 Jun 2006 19:53:06 +0100

On Fri, Jun 09, 2006 at 11:02:04PM +0200, [email-masked] wrote:

> +	read_lock(&dev_base_lock);
> +
> +	for (dev = dev_base; dev; dev = dev->next)
> +		if (!strncmp(dev->name, devname, IFNAMSIZ))
> +			break;
> +
> +	if (!dev) {
> +		ret = -ENODEV;
> +		goto out;
> +	}
> +
> +	db = kmalloc(sizeof(*db), GFP_KERNEL);

deadlock.

Besides, holding references to net_device from userland is Not Good(tm).