From: Philip Craig <philipc@snapgear•com>
To: Jeff Garzik <jgarzik@pobox•com>
Cc: netdev@vger•kernel.org
Subject: [PATCH 1/2 resend] 8139cp: fix eeprom read command length
Date: Wed, 21 Jun 2006 11:33:26 +1000 [thread overview]
Message-ID: <20060621013337.789014000@snapgear.com> (raw)
In-Reply-To: 4497B73A.4080804@pobox.com
[-- Attachment #1: 8139cp-read-eeprom.patch --]
[-- Type: text/plain, Size: 863 bytes --]
The read command for the 93C46/93C56 EEPROMS should be 3 bits plus
the address. This doesn't appear to affect the operation of the
read command, but similar errors for write commands do cause failures.
Signed-off-by: Philip Craig <philipc@snapgear•com>
Index: linux-2.6.17-rc6/drivers/net/8139cp.c
===================================================================
--- linux-2.6.17-rc6.orig/drivers/net/8139cp.c 2006-06-14 16:02:00.000000000 +1000
+++ linux-2.6.17-rc6/drivers/net/8139cp.c 2006-06-14 16:03:29.000000000 +1000
@@ -1628,7 +1628,7 @@ static int read_eeprom (void __iomem *io
eeprom_delay ();
/* Shift the read command bits out. */
- for (i = 4 + addr_len; i >= 0; i--) {
+ for (i = 3 + addr_len - 1; i >= 0; i--) {
int dataval = (read_cmd & (1 << i)) ? EE_DATA_WRITE : 0;
writeb (EE_ENB | dataval, ee_addr);
eeprom_delay ();
--
next prev parent reply other threads:[~2006-06-21 1:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-14 6:43 [PATCH 1/2] 8139cp: fix eeprom read command length Philip Craig
2006-06-20 8:52 ` Jeff Garzik
2006-06-21 1:33 ` Philip Craig [this message]
2006-06-23 3:20 ` [PATCH 1/2 resend] " Jeff Garzik
2006-06-21 1:33 ` [PATCH 2/2 resend] 8139cp: add ethtool eeprom support Philip Craig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060621013337.789014000@snapgear.com \
--to=philipc@snapgear$(echo .)com \
--cc=jgarzik@pobox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox