From: Brice Goglin <brice@myri•com>
To: netdev@vger•kernel.org
Subject: [PATCH 2/2] myri10ge - drop workaround pci_save_state() disabling MSI
Date: Thu, 22 Jun 2006 21:12:36 -0400 [thread overview]
Message-ID: <20060623011235.GB18337@myri.com> (raw)
In-Reply-To: <20060623011043.GA18234@myri.com>
[PATCH] myri10ge - drop workaround pci_save_state() disabling MSI
We don't need to restore the state right after saving it for later recovery
since commit 99dc804d9bcc2c53f4c20c291bf4e185312a1a0c (PCI: disable msi mode
in pci_disable_device) now prevents pci_save_state() from disabling MSI.
Signed-off-by: Brice Goglin <brice@myri•com>
---
drivers/net/myri10ge/myri10ge.c | 2 --
1 file changed, 2 deletions(-)
Index: linux-mm/drivers/net/myri10ge/myri10ge.c
===================================================================
--- linux-mm.orig/drivers/net/myri10ge/myri10ge.c 2006-06-22 20:42:34.000000000 -0400
+++ linux-mm/drivers/net/myri10ge/myri10ge.c 2006-06-22 20:42:45.000000000 -0400
@@ -2726,8 +2726,6 @@
/* Save configuration space to be restored if the
* nic resets due to a parity error */
myri10ge_save_state(mgp);
- /* Restore state immediately since pci_save_msi_state disables MSI */
- myri10ge_restore_state(mgp);
/* Setup the watchdog timer */
setup_timer(&mgp->watchdog_timer, myri10ge_watchdog_timer,
prev parent reply other threads:[~2006-06-23 1:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 1:10 [PATCH 0/2] myri10ge - drop 2 workarounds that have been fixed in the PCI core Brice Goglin
2006-06-23 1:11 ` [PATCH 1/2] myri10ge - drop workaround for the missing AER ext cap on nVidia CK804 Brice Goglin
2006-06-23 3:35 ` Jeff Garzik
2006-06-23 1:12 ` Brice Goglin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623011235.GB18337@myri.com \
--to=brice@myri$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox