From: Dave Jones <davej@redhat•com>
To: Stephen Hemminger <shemminger@osdl•org>
Cc: Jeff Garzik <jgarzik@pobox•com>, netdev@vger•kernel.org
Subject: Re: [PATCH] mark sk98lin driver for removal
Date: Sat, 22 Jul 2006 19:17:03 -0400 [thread overview]
Message-ID: <20060722231703.GB8042@redhat.com> (raw)
In-Reply-To: <20060722141150.5994fee1@localhost.localdomain>
On Sat, Jul 22, 2006 at 02:11:50PM -0700, Stephen Hemminger wrote:
> The sk98lin driver is now superseded by the skge driver. I wanted to just
> let the old driver wither and die from old age, but there are still bugs
> that are too painful to fix.
>
> See http://bugzilla.kernel.org/show_bug.cgi?id=6780
> The board crashes repeatedly after 2 weeks. It probably is something
> in the vendor MIB code. That code is a mess, and starting over was one
> of the motivations for creating the skge driver.
>
> So rather than add more bondo to the old beater to cover the rusty bits,
> throw it in the dustbin.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl•or
After a huge number of bug reports in Fedora 'went away' when we
switched our users to using skge instead, I wholeheartedly endorse this.
sk98lin is a disaster. The last time I looked the vendor out-of-tree
driver had a huge delta vs mainline, and backed out numerous fixes
made to it in the mainline kernel. It's a huge effort to get the 'good bits'
out of that patch, and letting it die is the only sensible solution IMO.
ACKed-by: Dave Jones <davej@redhat•com>
> +SK98LIN GIGABBIT ETHERNET DRIVER
typo :-)
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-07-22 23:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-22 21:11 [PATCH] mark sk98lin driver for removal Stephen Hemminger
2006-07-22 23:17 ` Dave Jones [this message]
2006-07-23 2:17 ` John W. Linville
2006-07-29 4:35 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-08-15 13:18 Michael Stone
2006-08-15 18:03 ` Stephen Hemminger
2006-08-15 18:42 ` Michael Stone
2006-08-17 15:21 ` Michael Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060722231703.GB8042@redhat.com \
--to=davej@redhat$(echo .)com \
--cc=jgarzik@pobox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@osdl$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox