Subject: Re: [PATCH wireless-dev 2/5] orinoco: Switch to d80211.h

From: Christoph Hellwig <[email-masked]>
Date: Mon, 24 Jul 2006 05:03:55 +0100

On Sun, Jul 23, 2006 at 08:40:20PM -0700, Michael Wu wrote:
> orinoco: Switch to d80211.h
> 
> This patch "converts" the orinoco driver to use d80211.h instead of
> ieee80211.h. It also copies the IEEE80211_DATA_LEN definition to
> d80211.h for use by the stack and drivers.

NACK for all of these patches.  The names in ieee80211.h

 a) make a whole lot more sense
 b) are used all over the kernel already

please convert the devicescape stack to reuse existing infrastrucure instead,
and that starts with things as simple as names for constants and data
structures in headers.