From: Christoph Hellwig <hch@lst•de>
To: Roland Dreier <rdreier@cisco•com>
Cc: David Miller <davem@davemloft•net>, hch@lst•de, netdev@vger•kernel.org
Subject: Re: [PATCH 1/2] remove CONFIG_HAVE_ARCH_DEV_ALLOC_SKB
Date: Wed, 26 Jul 2006 09:58:25 +0200 [thread overview]
Message-ID: <20060726075825.GB28526@lst.de> (raw)
In-Reply-To: <ada4px6ipxc.fsf@cisco.com>
On Mon, Jul 24, 2006 at 03:44:15PM -0700, Roland Dreier wrote:
> > skbuff.h has an #ifndef CONFIG_HAVE_ARCH_DEV_ALLOC_SKB to allow
> > architectures to reimplement __dev_alloc_skb. It's not set on any
> > architecture and now that we have an architecture-overrideable
> > NET_SKB_PAD there is not point at all to have one either.
>
> I missed this when hch first posted it, sorry.
>
> But my impression was that the intent of the config option was to let
> Xen hook __dev_alloc_skb() to allocate special receive skbs to handle
> their page-flipping virtual network device. Which goes beyond
> NET_SKB_PAD.
>
> So the real question is about Xen hooks I guess -- and given where the
> rest of Xen is, it probably does make sense to go ahead and strip this
> out.
If xen wants to use something else then dev_alloc_skb in their virtual
network driver that's totall fine. No need to override the definiton of
dev_alloc_skb for that, though. They can add their own xen_alloc_skb or
opencode the operation they want for it.
Note that overriding dev_alloc_skb is not just utterly pointless but would
even be harmfull in the case they'd finally add pci support for non-dom0
domains and used normaly NIC drivers in there.
prev parent reply other threads:[~2006-07-26 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 9:10 [PATCH 1/2] remove CONFIG_HAVE_ARCH_DEV_ALLOC_SKB Christoph Hellwig
2006-07-24 22:30 ` David Miller
2006-07-24 22:44 ` Roland Dreier
2006-07-26 7:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060726075825.GB28526@lst.de \
--to=hch@lst$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rdreier@cisco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox