Subject: Re: [PATCH 1/2] forcedeth: coding style cleanups (rev2)

From: Stephen Hemminger <[email-masked]>
Date: Thu, 27 Jul 2006 12:24:29 -0700

On Thu, 27 Jul 2006 21:21:14 +0200
Michael Buesch <[email-masked]> wrote:

> On Thursday 27 July 2006 19:48, Stephen Hemminger wrote:
> > --- sky2.orig/drivers/net/forcedeth.c	2006-07-13 12:53:48.000000000 -0700
> > +++ sky2/drivers/net/forcedeth.c	2006-07-27 10:45:49.000000000 -0700
> > @@ -381,21 +381,21 @@
> >  
> >  /* Big endian: should work, but is untested */
> >  struct ring_desc {
> > -	u32 PacketBuffer;
> > -	u32 FlagLen;
> > +	u32 buf;
> > +	u32 flaglen;
> >  };
> >  
> >  struct ring_desc_ex {
> > -	u32 PacketBufferHigh;
> > -	u32 PacketBufferLow;
> > -	u32 TxVlan;
> > -	u32 FlagLen;
> > +	u32 bufhigh;
> > +	u32 buflow;
> > +	u32 txvlan;
> > +	u32 flaglen;
> >  };
> 
> Shouldn't these two structs be __attribute__((packed)) ?
> 

Not really necessary since the elements are all the same size.
Plus, this was a style cleanup patch...