Subject: Re: [PATCH 1/7] NetLabel: documentation

From: David Miller <[email-masked]>
Date: Fri, 28 Jul 2006 00:51:04 -0700 (PDT)

From: [email-masked]
Date: Mon, 17 Jul 2006 11:52:25 -0400

> +CIPSOv4 Variables:
> +
> +cipso_cache_enable - BOOLEAN
 ...
> +cipso_cache_bucket_size - INTEGER
 ...
> +cipso_rbm_optfmt - BOOLEAN
 ...
> +cipso_rbm_structvalid - BOOLEAN
 ...

We need some more information for these entries.

First, list the default value these sysctls will have.
This is consistent with other entries in this file.  If
there is a compelling argument to support the default
value, please mention it.

Second, cipso_cache_bucket_size is still opaque, there is
nothing in the description with describes the units this
value is specified in, nor in fact what it really controls.
Does it say how deep the hash chains of the hash table are
allowed to grow to?  Otherwise, what does it control and what
are the consequences of using different values?