From: David Miller <davem@davemloft•net>
To: nakam@linux-ipv6•org
Cc: yoshfuji@linux-ipv6•org, anttit@tcs•hut.fi, vnuorval@tcs•hut.fi,
netdev@vger•kernel.org, usagi-core@linux-ipv6•org
Subject: Re: [PATCH 1/23] [PATCH] [XFRM]: Add XFRM_MODE_xxx for future use.
Date: Tue, 01 Aug 2006 16:52:32 -0700 (PDT) [thread overview]
Message-ID: <20060801.165232.95060501.davem@davemloft.net> (raw)
In-Reply-To: <11541653852481-git-send-email-nakam@linux-ipv6.org>
From: Masahide NAKAMURA <nakam@linux-ipv6•org>
Date: Sat, 29 Jul 2006 18:29:45 +0900
> Transformation mode is used as either IPsec transport or tunnel.
> It is required to add two more items, route-optimization and inbound trigger
> by Mobile IPv6.
> Based on MIPL2 kernel patch.
This change looks fine, but please explain the inconsistent
transformation done in xfrm4_encap() vs. xfrm6_encap().
In xfrm4_encap() the test is modified like this:
> - if (!x->props.mode) {
> + if (x->props.mode == XFRM_MODE_TRANSPORT) {
specifically allowing only XFRM_MODE_TRANSPORT, whereas in
xfrm6_encap() we do this:
> - if (!x->props.mode) {
> + if (x->props.mode != XFRM_MODE_TUNNEL) {
which changes the test to match all non-tunnels.
Unless there is a reason to do things differently, we should make the
checks identical even if ipv4 will never use values other than
XFRM_MODE_TUNNEL and XFRM_MODE_TRANSPORT.
next prev parent reply other threads:[~2006-08-01 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 9:29 [PATCH 1/23] [PATCH] [XFRM]: Add XFRM_MODE_xxx for future use Masahide NAKAMURA
2006-08-01 23:52 ` David Miller [this message]
2006-08-02 1:34 ` Masahide NAKAMURA
2006-08-02 4:53 ` Herbert Xu
2006-08-02 8:07 ` Masahide NAKAMURA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060801.165232.95060501.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=anttit@tcs$(echo .)hut.fi \
--cc=nakam@linux-ipv6$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=usagi-core@linux-ipv6$(echo .)org \
--cc=vnuorval@tcs$(echo .)hut.fi \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox