Subject: Re: [PATCH] tg3: Fix tx race condition

From: David Miller <[email-masked]>
Date: Mon, 07 Aug 2006 20:04:07 -0700 (PDT)

From: "Michael Chan" <[email-masked]>
Date: Mon, 07 Aug 2006 19:46:26 -0700

> 4. Make tx_cons and tx_prod volatile to guarantee that
> tg3_start_xmit() and tg3_tx() will see the latest ring indices.

Marking variables volatile is always an error.

If the locks and memory barriers are in the right place,
you have nothing to worry about.  :-)